Batch playback polling into single IPC call to fix WebKitGTK crash#141
Merged
Batch playback polling into single IPC call to fix WebKitGTK crash#141
Conversation
The frontend polled 10-13 individual PlayerService methods every 250ms, creating ~60 Wails IPC messages/second through WebKit. This triggered a use-after-free bug in WebKitGTK 2.50.5's FormDataElement destructor (WTF::Vector<WebCore::FormDataElement>::~Vector at offset 0x9b0a6f). Add GetPlaybackStatus() that returns all playback state in a single struct, reducing IPC traffic from ~60 to ~4 messages/second.
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetPlaybackStatus()method that returns all frequently-polled playback state in a single struct (state, position, duration, volume, title, artist, album, shuffle, repeat, radio mode/station/artwork)NowPlayingBar.svelteto call this single method instead of 10-13 individualPlayerServicemethods per poll cycleRoot cause
WebKitGTK 2.50.5 has a use-after-free bug in
WTF::Vector<WebCore::FormDataElement>::~Vector()(offset0x9b0a6finlibwebkitgtk-6.0.so). The rapid creation and destruction of ~60 IPC message objects per second triggers a race condition in WebKit's internal cleanup, causing a NULL dereference ataddr=0x28during the destructor.Identified via crash log analysis from PR #140 which added
/proc/self/mapsto crash logs, allowingaddr2lineto pinpoint the exact function.Test plan
go test -tags nocgo ./...passesgo vet -tags nocgo ./...passesnpm run build)