fix: Sync GLOB_DAT allocation and writing conditions#1845
Merged
mati865 merged 1 commit intowild-linker:mainfrom Apr 16, 2026
Merged
fix: Sync GLOB_DAT allocation and writing conditions#1845mati865 merged 1 commit intowild-linker:mainfrom
mati865 merged 1 commit intowild-linker:mainfrom
Conversation
They went out of sync back in 1c40a0c.
eae379a to
9b5b442
Compare
Member
Author
|
Note that I have no clue which behaviour is the correct one, and I failed to create self-contained test. and with current main: I guess both versions would be fine as long as the resolved flags are sensible. |
davidlattimore
approved these changes
Apr 16, 2026
Member
davidlattimore
left a comment
There was a problem hiding this comment.
I attempted to reproduce from a test case and was also unsuccessful. Good to have things in sync in anycase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They went out of sync back in 1c40a0c.
This used to cause linking of x86_64 Android Chromium to fail as described in #1561 (comment), but no longer does since #1837.