Draft
Conversation
PhdrType, ShdrType, ShdrFlags, SymInfo
Member
davidlattimore
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for updating our code!
We're also happy to merge the change sooner and temporarily depend on object from github if you'd like to avoid merge conflicts. We're intending to release wild 0.9.0 in the next few weeks, but there's still a few things we want to fix first. We could merge your PR before 0.9.0 provided you were expecting an object release within a couple of weeks, or if we merge after 0.9.0, then we've likely got more leeway.
Contributor
Author
|
Thanks for taking a look, I'll keep working on it. I don't want to commit to any timeframe yet, so better to hold off merging anything for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm experimenting with adding newtypes to the low level API in the object crate. This involves significant numbers of breaking changes. The changes in this PR are a result of investigating the impact on wild, and I'd like your feedback on whether you consider these changes acceptable.
wild already defined a few newtypes, and this PR replaces their definitions with a reexport of the types from object. Similarly, the constant definitions become reexports too. The API that object provides is similar to wild's newtypes with a few differences:
The motivation for adding these newtypes in object is I guess the same reason that wild added its own: convenience methods and the Debug impl, as well as general type safety benefits.
For reference, the object PR is gimli-rs/object#878. This PR is still far from complete, so there are likely to be more changes needed in wild as other newtypes are added. I'm happy to do all the fixes needed in wild if this work proceeds.