Skip to content

Feat/solana devnet#2

Open
Cooper-Kunz wants to merge 3 commits intomainfrom
feat/solana-devnet
Open

Feat/solana devnet#2
Cooper-Kunz wants to merge 3 commits intomainfrom
feat/solana-devnet

Conversation

@Cooper-Kunz
Copy link
Copy Markdown
Member

Adds Solana Devnet support for creating assets on Doppler's Solana AMM

Comment thread docs/api-reference.md
- `migration.type = "uniswapV3"` is explicitly unsupported (returns `501 MIGRATION_NOT_IMPLEMENTED`)
- `governance: false` (or omitted) for no governance
- `governance: true` (or `{ enabled: true }`) for default token-holder governance (OpenZeppelin Governor)
- EVM requests continue to use the existing EVM schema.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should fix/revert

Comment thread docs/api-reference.md
- `pairing?: { numeraireAddress? }`
- `pricing?: { numerairePriceUsd? }`
- `governance?: false`
- `migration?: { type: "noOp" }`
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

james to confirm

Comment thread docs/api-reference.md
- `governance?: false`
- `migration?: { type: "noOp" }`
- `auction:`
- `type: "multicurve"`:
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider reverting

Comment thread docs/api-reference.md
- exit/migration behavior:
- migrate immediately when `maxProceeds` is reached
- otherwise migrate at auction maturity only if `minProceeds` is reached
- `type: "xyk"`
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more clearly defined types, to add to glossary

Comment thread docs/api-reference.md

#### Solana request constraints

- Solana support is create-only in this iteration.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standards guidance: always speak as truth, not a stage of iteration

Comment thread docs/api-reference.md
- if a prior create attempt crashed/restarted after tx submit and left the key `in_progress`, retries fail closed with `409 IDEMPOTENCY_KEY_IN_DOUBT`
- when `IDEMPOTENCY_REQUIRE_KEY=true` (always true in shared mode), create requests without header return `422 IDEMPOTENCY_KEY_REQUIRED`
- EVM crash-window retries can return `409 IDEMPOTENCY_KEY_IN_DOUBT`
- Solana ambiguous confirmation retries can return `409 SOLANA_LAUNCH_IN_DOUBT`
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in doubt is confusing

Comment thread docs/configuration.md
- `SOLANA_KEYPAIR`
- JSON array of 64 secret-key bytes
- `SOLANA_CONFIRM_TIMEOUT_MS`
- `SOLANA_DEVNET_USE_ALT`
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could simplify

Comment thread docs/errors.md
- `UNAUTHORIZED`

### Launch creation and policy
### EVM launch creation and policy
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should just call it launch then per network, don't need to top level differentiate between evm and svm

Comment thread src/core/config.ts
mainnetBetaWsUrl?: string;
keypairBytes?: Uint8Array;
confirmTimeoutMs: number;
useAlt: boolean;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can likely remove alt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant