feat: improve start id exclusion to avoid race condition fk error#730
Open
MatheusLeall wants to merge 2 commits intomainfrom
Open
feat: improve start id exclusion to avoid race condition fk error#730MatheusLeall wants to merge 2 commits intomainfrom
MatheusLeall wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 98.62% 98.62% -0.01%
==========================================
Files 647 648 +1
Lines 34916 34924 +8
==========================================
+ Hits 34436 34443 +7
- Misses 480 481 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Makes sense update a migration file that is already on database?
Collaborator
Author
There was a problem hiding this comment.
You're right, I'll create a new migration for that. I hadn't noticed that the SQL files were called as migration execution in the init file; I'll follow the existing pattern in the repository.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solução para o problema de FK resultante de um race condition que está ocorrendo entre uma task do celery e o acionamento de uma trigger no banco de dados
Tarefa relacionada: https://vtex-dev.atlassian.net/jira/software/projects/ENGINE/boards/4798/backlog?selectedIssue=ENGINE-3008