-
Notifications
You must be signed in to change notification settings - Fork 65
fix(cc-components): show dialed number instead of entrypoint for outdial calls #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
6600981
336ea0b
5baf501
de91094
8617d76
abc1049
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -198,7 +198,7 @@ exports[`CallControlCADComponent Snapshots should handle edge cases and control | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -376,7 +376,7 @@ exports[`CallControlCADComponent Snapshots should handle edge cases and control | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -908,7 +908,7 @@ exports[`CallControlCADComponent Snapshots should render basic call states and m | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| chat-customer@example.com | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The updated Useful? React with 👍 / 👎. |
||
| </span> | ||
| </mdc-text> | ||
| <mdc-tooltip | ||
|
|
@@ -918,7 +918,7 @@ exports[`CallControlCADComponent Snapshots should render basic call states and m | |
| <mdc-text | ||
| class="md-text-wrapper" | ||
| > | ||
| No Phone Number | ||
| chat-customer@example.com | ||
| </mdc-text> | ||
| </mdc-tooltip> | ||
| </div> | ||
|
|
@@ -1178,7 +1178,7 @@ exports[`CallControlCADComponent Snapshots should render basic call states and m | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -1438,7 +1438,7 @@ exports[`CallControlCADComponent Snapshots should render basic call states and m | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -1925,7 +1925,7 @@ exports[`CallControlCADComponent Snapshots should render consultation and wrapup | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -2219,7 +2219,7 @@ exports[`CallControlCADComponent Snapshots should render consultation and wrapup | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -2480,7 +2480,7 @@ exports[`CallControlCADComponent Snapshots should render consultation and wrapup | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
@@ -2741,7 +2741,7 @@ exports[`CallControlCADComponent Snapshots should render consultation and wrapup | |
| </strong> | ||
|
|
||
| <span> | ||
| No Phone Number | ||
| 555-123-4567 | ||
| </span> | ||
| </mdc-text> | ||
| </div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated
chat-media-typesnapshot now expectschat-customer@example.comunder Phone Number, butrenderPhoneNumberincall-control-cad.tsxreturnsNO_PHONE_NUMBERwhenever the interaction is neither social nor telephony (mediaType: 'chat'hits that branch). This makes the committed snapshot inconsistent with the component logic and will cause the CallControlCAD snapshot test to fail for the chat scenario.Useful? React with 👍 / 👎.