Skip to content

ci: enable Windows ARM64 build in GitHub Actions #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sykuang wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

ci: enable Windows ARM64 build in GitHub Actions #3186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/build-helper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ jobs:
runner: ubuntu-24.04-arm
- platform: "windows"
runner: "windows-latest"
# - platform: "windows"
# runner: "windows-11-arm64-16core"
- platform: "windows"
runner: "windows-11-arm"
Comment on lines +31 to +32
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that ARM runner is enabled and signing steps still use x64 Keylocker tooling.
rg -n -C2 'windows-11-arm|Set up certificate \(Windows only\)|Setup Keylocker KSP|Keylockertools-windows-x64.msi|github.event_name != '\''workflow_dispatch'\''' .github/workflows/build-helper.yml

Repository: wavetermdev/waveterm

Length of output: 2066

🌐 Web query:

Is DigiCert Signing Manager Keylocker officially supported on Windows 11 ARM64 runners, and is Keylockertools-windows-x64.msi supported for CI code signing on ARM64?

💡 Result:

No, DigiCert Signing Manager Keylocker is not officially supported on Windows 11 ARM64 runners. Official documentation lists support for Windows 11 under 64-bit x64 architecture only, with no mention of ARM64. The Windows client installer is exclusively Keylockertools-windows-x64.msi, indicating x64 binaries. While JCE library supports ARM via Java, core tools like SMCTL, PKCS11, and KSP are Windows x64-specific. GitHub Actions workflows use windows-latest (x64), not windows-latest-arm64. Keylockertools-windows-x64.msi is not natively supported for CI code signing on ARM64 runners, as it is an x64 MSI that may not install or run properly on ARM64 without emulation, which is unconfirmed and not recommended for production CI.

Citations:

ARM release builds cannot be signed with the current setup.

Adding windows-11-arm runner at line 33 enables ARM release builds, but the signing workflow still downloads and installs Keylockertools-windows-x64.msi (line 122) for all Windows jobs. DigiCert Signing Manager Keylocker is not officially supported on Windows ARM64; the installer is x64-exclusive and will not run on ARM runners. The reported test used workflow_dispatch (signing skipped), so ARM release signing was never tested.

Remove the windows-11-arm runner or add separate ARM-compatible signing logic before ARM releases can proceed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-helper.yml around lines 32 - 33, The workflow
currently adds the "windows-11-arm" runner but still unconditionally installs
the x64-only Keylockertools MSI ("Keylockertools-windows-x64.msi"), which fails
on ARM; either remove the "windows-11-arm" runner or add conditional logic
around the signing job to detect runner labels (e.g., check runner
OS/architecture or job matrix value "platform" == "windows" vs "windows-arm")
and skip or use ARM-compatible signing steps for ARM builds (or only run the MSI
installation when platform == "windows" and not "windows-11-arm"), and ensure
the signing step that downloads "Keylockertools-windows-x64.msi" is gated behind
that condition or replaced with ARM-capable signing logic.

runs-on: ${{ matrix.runner }}
steps:
- uses: actions/checkout@v6
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
command: npm ci --no-audit --no-fund
retry_on: error
max_attempts: 3
timeout_minutes: 5
timeout_minutes: 15
env:
GIT_ASKPASS: "echo"
GIT_TERMINAL_PROMPT: "0"
Expand Down Expand Up @@ -156,6 +156,7 @@ jobs:
CSC_LINK: ${{ steps.variables.outputs.SM_CLIENT_CERT_FILE }}
CSC_KEY_PASSWORD: ${{ secrets.SM_CLIENT_CERT_PASSWORD }}
STATIC_DOCSITE_PATH: ${{env.STATIC_DOCSITE_PATH}}
CC: ${{ contains(matrix.runner, 'arm') && 'zig cc -target aarch64-windows-gnu' || '' }}
shell: powershell # electron-builder's Windows code signing package has some compatibility issues with pwsh, so we need to use Windows Powershell

# Upload artifacts to the S3 staging and to the workflow output for the draft release job
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ tasks:
vars:
UP_VERSION: '{{ replace "v" "" (index .MATCH 0)}}'
cmd: |
wingetcreate update {{.WINGET_PACKAGE}} -s -v {{.UP_VERSION}} -u "https://{{.RELEASES_BUCKET}}/{{.APP_NAME}}-win32-x64-{{.UP_VERSION}}.msi" -t {{.GITHUB_TOKEN}}
wingetcreate update {{.WINGET_PACKAGE}} -s -v {{.UP_VERSION}} -u "https://{{.RELEASES_BUCKET}}/{{.APP_NAME}}-win32-x64-{{.UP_VERSION}}.msi" "https://{{.RELEASES_BUCKET}}/{{.APP_NAME}}-win32-arm64-{{.UP_VERSION}}.msi" -t {{.GITHUB_TOKEN}}

dev:installwsh:
desc: quick shortcut to rebuild wsh and install for macos arm64
Expand Down