first stab at watch and serve implementation#745
Open
boringcactus wants to merge 3 commits intowasm-bindgen:masterfrom
Open
first stab at watch and serve implementation#745boringcactus wants to merge 3 commits intowasm-bindgen:masterfrom
watch and serve implementation#745boringcactus wants to merge 3 commits intowasm-bindgen:masterfrom
Conversation
Open
Contributor
|
Hi @boringcactus; thanks so much for this PR! Sorry this has taken a while to review. @ashleygwilliams and I had a call about this PR yesterday and we reviewed it together. We found this PR to be an excellent starting point, and are happy to land the code. A few adjustments will need to be made though: specifically fixing the merge conflict, and adding tests. But @ashleygwilliams has said she would pick that up. Either way we're really excited about this PR, and wanted to let you know we're planning to move ahead with the work you've done! Thanks so much! |
|
Hi team, any news on this PR? I came from cargo-web and would love that we have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC for this feature, rustwasm/rfcs#10, hasn't been formally accepted yet, but I was wondering how hard it'd be to build these features, and apparently it's possible to build a simple but functional prototype in <200 lines of new code.
Things I like about this code:
#[structopt(flatten)]RwLockis perfect for holding the server until the build finisheshyper-staticfilecrate more effectively)Things that need to be resolved:
cargo-watchcrate appears to watch the entire crate directory except for things in.gitignoreand a handful of manually defined exclusions