Skip to content

fix: expand VS Code predefined variables in all path-valued settings#779

Merged
sheremet-va merged 4 commits intomainfrom
copilot/fix-path-settings-substitution
Apr 27, 2026
Merged

fix: expand VS Code predefined variables in all path-valued settings#779
sheremet-va merged 4 commits intomainfrom
copilot/fix-path-settings-substitution

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 24, 2026

  • Add substituteVariables function to handle ${workspaceFolder}, ${workspaceFolderBasename}, ${userHome}, ${env:NAME}, ${pathSeparator} variables
  • Extract resolvePathWithSubstitution private helper to avoid duplicated substitution+resolve logic
  • Update resolveConfigPath to accept optional workspaceFolder for multi-root workspace resolution
  • Apply variable substitution to all path-valued settings: rootConfig, workspaceConfig, nodeExecutable, terminalShellPath, vitestPackagePath, and debugOutFiles
  • Add unit tests for substituteVariables in config.test.ts
  • Apply oxfmt formatting fixes

Copilot AI and others added 2 commits April 24, 2026 12:52
Copilot AI changed the title [WIP] Fix path settings substitution for vitest configuration fix: expand VS Code predefined variables in all path-valued settings Apr 24, 2026
Copilot AI requested a review from sheremet-va April 24, 2026 12:55
@sheremet-va
Copy link
Copy Markdown
Member

@copilot run pnpm fmt:fix command to fix formatting errors

Agent-Logs-Url: https://github.com/vitest-dev/vscode/sessions/7f2f0e5f-200e-486f-b687-3bc35e2dc22a

Co-authored-by: sheremet-va <16173870+sheremet-va@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 24, 2026

@copilot run pnpm fmt:fix command to fix formatting errors

Done in 7521241.

@sheremet-va sheremet-va marked this pull request as ready for review April 27, 2026 11:29
@sheremet-va sheremet-va merged commit 71cf6ab into main Apr 27, 2026
5 checks passed
@sheremet-va sheremet-va deleted the copilot/fix-path-settings-substitution branch April 27, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vitest.rootConfig (and other path settings) don't resolve ${workspaceFolder}

2 participants