fix: export missing Vue component prop types#1760
Open
velocitysystems wants to merge 1 commit intovidstack:mainfrom
Open
fix: export missing Vue component prop types#1760velocitysystems wants to merge 1 commit intovidstack:mainfrom
velocitysystems wants to merge 1 commit intovidstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportkeyword toChapterTitlePropsinsrc/elements/define/chapter-title-element.tsChapterTitleProps,MediaLayoutProps, andSpinnerPropsfromsrc/exports/components.tsThese three types are imported by the generated
vue.d.tsfrom'./index', but were never exported from the public barrel. This silently breaks the entiredeclare module 'vue'augmentation, causing all vidstack custom elements to be unrecognized in Vue templates.Fixes #1759
Test plan
skipLibCheck: falseandstrictTemplates: truevidstack/vuetypes and use vidstack custom elements in a templatenpx vue-tsc --noEmitand confirm no missing export or TS2339 errors