Ruby 3.4 support

[okapusta]

➜  language_detection git:(ruby-3.4) ✗ ruby -v          
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [x86_64-darwin23]
➜  language_detection git:(ruby-3.4) ✗ bundle exec rake 
Extension already compiled. To recompile set env variable RECOMPILE=true.
/Users/oskarkapusta/.rbenv/versions/3.4.1/bin/ruby -w -I"lib:lib:test" /Users/oskarkapusta/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/language_detection_test.rb" 
/Users/oskarkapusta/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/shoulda-matchers-4.5.1/lib/shoulda/matchers/doublespeak.rb:2: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
Loaded suite /Users/oskarkapusta/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader
Started
Finished in 0.008427 seconds.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
7 tests, 94 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
830.66 tests/s, 11154.62 assertions/s

You can add logger to your Gemfile or gemspec to silence this warning.

What do you think?

[vhyza]

Thank you @okapusta!

When I tried to run it with clean Ruby 3.4.2, I had a problem with missing bigdecimal so it would be great to add it too as it seems it was removed from Ruby 3.4 and it is required by shoulda.

If I understood it right, csv and bigdecimal were removed from Ruby 3.4 (and logger will be removed in 3.5) so I would propose to put into gemspec something like the following:

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.4.0')
  gem.add_dependency 'logger'
  gem.add_development_dependency "csv", "~> 3"
  gem.add_development_dependency 'bigdecimal', "~> 3"
end

I'm not able to try it with Ruby 2.5, which is the lowest requirement from the gemspec. I can't install it on my workstation for some reason and the Docker image is so old that the Debian repositories are not working (and one needs to install git and build-essential to build the gem).

I was able to run it with Ruby 2.6. But I think that these days we can increase the minimum requirements to Ruby 2.6, as Ruby 2.5 is more than 4 years EOL. What do you think?