[7/9] fix: handle directories in dep-info source file hashing#5
Open
mmastrac wants to merge 1 commit intovercel/file-clone-compressfrom
Open
[7/9] fix: handle directories in dep-info source file hashing#5mmastrac wants to merge 1 commit intovercel/file-clone-compressfrom
mmastrac wants to merge 1 commit intovercel/file-clone-compressfrom
Conversation
mmastrac
changed the base branch from
vercel/file-clone-reflink
to
vercel/03-file-clone-reflink
mmastrac
changed the title
mmastrac
changed the base branch from
vercel/03-file-clone-reflink
to
vercel/file-clone-reflink
mmastrac
force-pushed
the
vercel/file-clone-reflink
branch
from
5344dad to
f487cc2
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
9ea5c59 to
59848e7
Compare
mmastrac
changed the title
mmastrac
force-pushed
the
vercel/file-clone-reflink
branch
from
f487cc2 to
a7bc6d3
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
2 times, most recently
from
79c28ed to
afd0422
Compare
mmastrac
changed the title
mmastrac
changed the base branch from
vercel/file-clone-reflink
to
vercel/file-clone-compress
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
b668492 to
c779b68
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
2 times, most recently
from
19a11db to
684ec28
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
226e9df to
c3ebfff
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
2 times, most recently
from
3f6e50b to
7ad84a3
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
2 times, most recently
from
2afce2b to
f12d053
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
7ad84a3 to
e491a69
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
f12d053 to
136498c
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
e491a69 to
0237f6e
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
136498c to
4be87c8
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
2 times, most recently
from
9cefa6c to
a321d4a
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
4be87c8 to
0106a7d
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
a321d4a to
bf0aca6
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
2 times, most recently
from
ddb7117 to
eed7dde
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
bf0aca6 to
9590506
Compare
mmastrac
changed the title
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
9590506 to
bd2a312
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
eed7dde to
f7e3b82
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
bd2a312 to
62e8073
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
2 times, most recently
from
3d27feb to
cf104ad
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
62e8073 to
03f037d
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
cf104ad to
66992c5
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
03f037d to
3e055b2
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
66992c5 to
dd8329f
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
3e055b2 to
37ccf40
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
37ccf40 to
db0b087
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
from
dd8329f to
0511c15
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
db0b087 to
4fdbbf4
Compare
mmastrac
force-pushed
the
vercel/file-clone-compress
branch
2 times, most recently
from
fbb6657 to
5e9fb55
Compare
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
4fdbbf4 to
2715294
Compare
When proc_macro::tracked::path() registers a directory as a dependency, rustc's dep-info output includes the directory path. sccache previously crashed with "Is a directory" when trying to hash these paths. Now recursively hashes all files within the directory (sorted for determinism), using relative paths as delimiters. This correctly captures directory dependencies so cache invalidation works when any file in the tracked directory changes. Fixes: mozilla#2653 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mmastrac
force-pushed
the
vercel/fix-dir-dep-info
branch
from
2715294 to
d59ecfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mozilla#2653.
proc_macro::tracked::path()registers a directory as a dependency, rustc's dep-info includes the directory pathturbopack-nodethat useinclude_dir!with nightly proc macro trackingStack: 5/6