Downgrade missing required CSV column from error to warning#161
Downgrade missing required CSV column from error to warning#161
Conversation
When importing a CSV that doesn't contain all required columns defined in the database schema, the validation was throwing an exception that halted the entire import. This changes the behavior to emit a warning instead, allowing the import to proceed with null values for missing columns. The database layer will handle any actual constraint violations on a per-row basis. Fixes: CLOUD-3K9V Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fix Confidence: 95/100The fix is minimal and targeted: changing a throw to a warning in validateCSVHeaders. The root cause is clear from the error message and code. All CI checks pass. The only slight uncertainty is whether downstream consumers expect the exception for control flow, but the CSV.exportGroupDatabases already catches Throwable and converts to an error, so the warning path is strictly better for users. |
Summary
validateCSVHeadersmethod was throwing an exception that aborted the entire importCLOUD-3K9V: "CSV header validation failed: Missing required column: 'texte'" (11 occurrences)Test plan
testValidateCSVHeadersMissingRequiredColumnDoesNotThrow— verifies missing required columns no longer throwtestValidateCSVHeadersAllRequiredPresent— verifies no issues when all required columns exist🤖 Generated with Claude Code