Skip to content

Fix:nested internal dispatch route context restoration#223

Open
HarshMN2345 wants to merge 1 commit into0.33.xfrom
Fix-nested-internal-dispatch-route-context-restoration
Open

Fix:nested internal dispatch route context restoration#223
HarshMN2345 wants to merge 1 commit into0.33.xfrom
Fix-nested-internal-dispatch-route-context-restoration

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Mar 12, 2026

Summary by CodeRabbit

  • New Features

    • Added server adapters for FPM and Swoole runtime environments.
    • Added Model interface for automatic JSON request parameter deserialization.
    • Added static file loading and serving with 2-year cache headers.
  • Breaking Changes

    • Main API class renamed from App to Http.
    • Validators moved to separate package; install utopia-php/validators separately.
    • Minimum PHP version increased from 8.1 to 8.3.

@HarshMN2345 HarshMN2345 changed the base branch from master to 0.33.x March 12, 2026 13:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

This pull request restructures the HTTP framework by renaming the core App class to Http and relocating it to the Utopia\Http namespace. The Request and Response classes are converted to abstract classes with concrete FPM and Swoole adapter implementations. Validator classes are removed and replaced with an external dependency. New features include a file management system, a model interface for parameter validation, and HTTP adapter infrastructure. Dependencies are updated, including a PHP version bump from 8.1 to 8.3, and configuration files (Dockerfile, docker-compose.yml) are simplified.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

The scope encompasses major architectural refactoring affecting core classes, introduction of multiple new adapter implementations with complex logic, removal of an entire validator subsystem in favor of external dependencies, significant test suite updates, and interconnected changes across namespaces and public APIs that require careful verification of correctness and completeness.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.60% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix:nested internal dispatch route context restoration' clearly summarizes the main change, which is fixing route context restoration for nested internal dispatches in the HTTP library.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Fix-nested-internal-dispatch-route-context-restoration
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant