Open
Conversation
rename helper functions to use the word "helper" instead of calling them "f" like normal test functions add comments in README.md to clarify the purpose of helpers this affects only the custom predicate benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename helper functions to use the word "helper" instead of calling them "f" like normal test functions
add comments in README.md to clarify the purpose of helpers
this affects only the custom predicate benchmarks
@hanwenguo please take a look, because this PR bumps the version number (v1.1). Note that I did the simplest possible renaming:
f->helper, and didn't also rename functions fromg->f, which would be more consistent with the rest of the benchmark, but seems like more trouble than it's worth because calling the first testfis not a good convention in the first place.