Differentiation test suite and tracer leak fix#243
Merged
astanziola merged 2 commits intomainfrom Mar 22, 2026
Merged
Conversation
7f52d9b to
a6773f4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage ? 80.42%
=======================================
Files ? 15
Lines ? 1216
Branches ? 0
=======================================
Hits ? 978
Misses ? 238
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differentiation test suite and tracer leak fix
Summary
tests/test_differentiation.py) verifyingjax.gradworks through all solvers w.r.t. all differentiable inputslaplacian_with_pmlthat causedhelmholtz_solverwithcheckpoint=Falseto fail underjax.gradTracer leak fix
FourierSerieslaplacian_with_pmllazily computedgradient.default_params(rho0)inside the function body (line 224 ofoperators.py). When GMRES re-tracedhelm_funcfor its adjoint withcheckpoint=False, this created new arrays inside thecustom_linear_solvetrace scope that escaped — causing anUnexpectedTracerError.Fix: moved
fft_rho0computation intofourier_laplacian_with_pml_initso it's pre-computed before tracing. Also addedinit_paramsto theOnGridvariant for consistency.Verified bitwise identical results (forward field, loss, gradient) before and after the fix.
Known issues documented as xfail
born_seriesuseslax.while_loopwhich doesn't support reverse-mode AD (CBS adjoint #189)Related issues