Merge question adding into codebase before pyodide changes#1365
Draft
Yamgirly wants to merge 3 commits intodevelop-jan-2024from
Draft
Merge question adding into codebase before pyodide changes#1365Yamgirly wants to merge 3 commits intodevelop-jan-2024from
Yamgirly wants to merge 3 commits intodevelop-jan-2024from
Conversation
This adds a page for submitting questions. Currently, submitted questions are made into files and stored in a separate folder awaiting review. The main changes are to preview.js, add_question.html, views.py, forms.py, and models.py (the latter three being under codewof/programming). Other changes are generally small and self-explanatory, typically extending a module to better support the ways the new interface is different.
Update to previous commit to comply with style requirements
Configured style checker to ignore the same issues with submitted questions as existing questions. Additionally added a whitespace check to the review process, as the style checker should ignore this on submitted files (due to the complexity that checking this as part of saving the file would involve).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks
ℹ Additional Information