Merged
Conversation
Extract shared buffer-write operations (write_flat, patch_near, patch_list_header, write_bytes, alloc_segment, patch_segment_next) into free functions in buf.rs. Both Emitter and Region now delegate to these shared implementations, eliminating ~200 lines of copy-pasted code. Also: - Cache deref_raw() outside tight loops in session.rs methods (re_splice_list, filter_list, reverse_list, sort_list, dedup_list) to avoid redundant expose_provenance calls per iteration - Use with_capacity in Region::trim to avoid reallocations - Remove dead commented-out Emit<T> for Infallible impl Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_flat,patch_near,patch_list_header,write_bytes,alloc_segment,patch_segment_next) into free functions inbuf.rsEmitterandRegionnow delegate to shared implementations, eliminating ~200 lines of copy-pasted codederef_raw()outside tight loops in session methods to avoid redundantexpose_provenancecalls per iterationwith_capacityinRegion::trimto avoid reallocations during compactionEmit<T> for InfallibleimplTest plan
cargo test)MIRIFLAGS="-Zmiri-permissive-provenance" cargo +nightly miri test)cargo xtask lint)cargo clippy -p nearest --no-default-features)🤖 Generated with Claude Code