update-crds: add helm.sh/resource-policy: keep annotation to all CRDs#38
Open
update-crds: add helm.sh/resource-policy: keep annotation to all CRDs#38
Conversation
This prevents Helm from deleting CRDs during `helm uninstall`, which
could cause data loss by removing all custom resources in the cluster.
The annotation is now applied via kustomize overlays instead of
post-processing with yq. Each operator has its own kustomization.yaml
under kustomize/{chart}/ that references the upstream CRD source and
applies commonAnnotations, keeping the Makefile simpler and removing
the yq dependency.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wpjunior
force-pushed
the
proposal/helm-security
branch
from
e641796 to
d92f332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents Helm from deleting CRDs during
helm uninstall, which could cause data loss by removing all custom resources in the cluster.The annotation is now applied via kustomize overlays instead of post-processing with yq. Each operator has its own kustomization.yaml under kustomize/{chart}/ that references the upstream CRD source and applies commonAnnotations, keeping the Makefile simpler.