hrpc: More CheckAndMutate Tests with filterIfMissing#341
Open
cluckett-arista wants to merge 2 commits intotsuna:masterfrom
Open
hrpc: More CheckAndMutate Tests with filterIfMissing#341cluckett-arista wants to merge 2 commits intotsuna:masterfrom
cluckett-arista wants to merge 2 commits intotsuna:masterfrom
Conversation
filterIfMissing affects how CheckAndMutate behaves. We need tests covering this behvaior to demonstrate that the CAM request can succeed or fail depending on this parameter in the case where we pass a non-existent column to the cmp filter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 19.67% 19.74% +0.07%
==========================================
Files 55 56 +1
Lines 13059 13174 +115
==========================================
+ Hits 2569 2601 +32
- Misses 10316 10386 +70
- Partials 174 187 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filterIfMissing affects how CheckAndMutate behaves. We need tests covering this behvaior to demonstrate that the CAM request can succeed or fail depending on this parameter in the case where we pass a non-existent column to the cmp filter.