Conversation
ciacono
reviewed
Mar 20, 2026
ciacono
requested changes
Mar 20, 2026
Update TestErrorScanFromIDV2 to actually test the ScannerV2 path. It was calling the same test function as TestErrorScanFromID. This is the only place that testErrorScanFromIDV2 that is being used, so it was inlined into the test function.
aaronbee
force-pushed
the
scannerv2_test
branch
from
8357b1f to
778be78
Compare
ciacono
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TestErrorScanFromIDV2 to actually test the ScannerV2 path. It was calling the same test function as TestErrorScanFromID.
This is the only place that testErrorScanFromIDV2 that is being used, so it was inlined into the test function.