Skip to content

test: Add perf_analyzer dependency to L0_perf_vllm#8747

Open
mattwittwer wants to merge 5 commits intomainfrom
mwittwer/perf_vllm_update_dependencies
Open

test: Add perf_analyzer dependency to L0_perf_vllm#8747
mattwittwer wants to merge 5 commits intomainfrom
mwittwer/perf_vllm_update_dependencies

Conversation

@mattwittwer
Copy link
Copy Markdown
Contributor

@mattwittwer mattwittwer commented Apr 17, 2026

What does the PR do?

Explicitly pip3 install perf_analyzer in qa/L0_perf_vllm/test.sh since tritonclient no longer pulls perf_analyzer automatically.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/vllm_backend#126

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

300551276

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@mattwittwer mattwittwer self-assigned this Apr 17, 2026
@mattwittwer mattwittwer changed the title draft: Add perf_analyzer dependency test: Add perf_analyzer dependency to L0_perf_vllm Apr 17, 2026
mc-nv
mc-nv previously approved these changes Apr 17, 2026
@mattwittwer mattwittwer requested review from mudit-eng and whoisj April 17, 2026 23:07
Comment thread qa/L0_perf_vllm/test.sh Outdated
Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com>
Comment thread qa/L0_perf_vllm/test.sh
EXPORT_FILE=profile-export-vllm-model.json

pip3 install tritonclient
pip3 install tritonclient[perf_analyzer]
Copy link
Copy Markdown
Contributor

@yinggeh yinggeh Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip3 install tritonclient[perf_analyzer]
pip3 install perf-analyzer

since it's recommended here https://github.com/triton-inference-server/perf_analyzer/blob/main/docs/install.md#pip. @mc-nv @ganeshku1 for clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants