Skip to content

test: fix: correct assertion #8732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
whoisj wants to merge 4 commits into
base: main
Choose a base branch
from
+39 −28
Draft

test: fix: correct assertion #8732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
460d9cf
test: fix: correct assertion
whoisj Apr 10, 2026
86fa656
fix other tests
whoisj Apr 10, 2026
d42cdb0
improve tests
whoisj Apr 15, 2026
4328eb8
fix error matching (again)
whoisj Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qa/L0_cuda_shared_memory/cuda_shared_memory_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ def test_exceeds_cshm_handle_size_limit(self):
try:
error_message = response.json().get("error", "")
self.assertIn(
"Request JSON size",
"request JSON size",
error_message,
)
self.assertIn(
Expand Down
11 changes: 11 additions & 0 deletions qa/L0_http/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
http_input_size_limit_test_models/
models/
python_unit_test_models/
unit_test_models/

*.log
client.log.*
curl.out
*.load.log.*
pswd
test_results.txt
14 changes: 7 additions & 7 deletions qa/L0_http/http_input_size_limit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def test_json_dtype_size_expansion_exceeds_limit_error(self):
f"Error message: {error_msg}", flush=True
) # Print the error message for debugging
self.assertIn(
"Request JSON size of ",
"request JSON size of ",
error_msg,
)
self.assertIn(
Expand Down Expand Up @@ -206,7 +206,7 @@ def test_default_limit_raw_binary(self):
# Verify error message contains size limit info
error_msg = response.content.decode()
self.assertIn(
"exceeds the maximum allowed value",
" exceeds the maximum allowed value of ",
error_msg,
"Expected error message about exceeding max input size",
)
Expand Down Expand Up @@ -282,7 +282,7 @@ def test_default_limit_json(self):
# Verify error message contains size limit info
error_msg = response.content.decode()
self.assertIn(
"Request JSON size of ",
"request JSON size of ",
error_msg,
)
self.assertIn(
Expand Down Expand Up @@ -366,7 +366,7 @@ def test_large_input_raw_binary(self):
# Verify error message contains size limit info
error_msg = response.content.decode()
self.assertIn(
"exceeds the maximum allowed value",
" exceeds the maximum allowed value of ",
error_msg,
"Expected error message about exceeding max input size",
)
Expand Down Expand Up @@ -536,7 +536,7 @@ def test_large_string_in_json(self):
# Verify error message
error_msg = response.content.decode()
self.assertIn(
"Request JSON size of ",
"request JSON size of ",
error_msg,
)
self.assertIn(
Expand Down Expand Up @@ -622,7 +622,7 @@ def test_default_limit_compressed(self):
# Verify error message contains size limit info
error_msg = response.content.decode()
self.assertIn(
"exceeds the maximum allowed value",
" data size exceeds the maximum allowed value of ",
error_msg,
"Expected error message about exceeding max input size",
)
Expand Down Expand Up @@ -696,7 +696,7 @@ def test_large_input_compressed(self):

error_msg = response.content.decode()
self.assertIn(
"exceeds the maximum allowed value",
" data size exceeds the maximum allowed value of ",
error_msg,
"Expected error message about exceeding max input size",
)
Expand Down
4 changes: 2 additions & 2 deletions qa/L0_http/http_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,11 @@ def test_loading_large_invalid_model(self):
try:
error_message = response.json().get("error", "")
self.assertIn(
"Request JSON size",
"request JSON size of ",
error_message,
)
self.assertIn(
" exceeds the maximum allowed input size. ",
" exceeds the maximum allowed input size of ",
error_message,
)
except ValueError:
Expand Down
36 changes: 18 additions & 18 deletions qa/L0_http/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ rm -f *.log.*
set -e

CLIENT_LOG=`pwd`/client.log
SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"

run_server
if [ "$SERVER_PID" == "0" ]; then
Expand Down Expand Up @@ -279,7 +279,7 @@ set -e
kill $SERVER_PID
wait $SERVER_PID

SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR} --model-control-mode=explicit"
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR} --model-control-mode=explicit"
run_server
if [ "$SERVER_PID" == "0" ]; then
echo -e "\n***\n*** Failed to start $SERVER\n***"
Expand Down Expand Up @@ -310,7 +310,7 @@ set -e
kill $SERVER_PID
wait $SERVER_PID

SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR} --model-control-mode=explicit"
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR} --model-control-mode=explicit"
run_server
if [ "$SERVER_PID" == "0" ]; then
echo -e "\n***\n*** Failed to start $SERVER\n***"
Expand All @@ -333,7 +333,7 @@ kill $SERVER_PID
wait $SERVER_PID

# Test with dynamic sequence models
SERVER_ARGS="--model-repository=`pwd`/models"
SERVER_ARGS="--allow-client-shm=true --model-repository=`pwd`/models"
SERVER_LOG="./inference_server_dyna.log"
CLIENT_LOG="./client_dyna.log"
run_server
Expand All @@ -360,7 +360,7 @@ kill $SERVER_PID
wait $SERVER_PID

# Test combinations of binary and JSON data
SERVER_ARGS="--model-repository=`pwd`/models"
SERVER_ARGS="--allow-client-shm=true --model-repository=`pwd`/models"
SERVER_LOG="./inference_server_binaryjson.log"
run_server
if [ "$SERVER_PID" == "0" ]; then
Expand Down Expand Up @@ -549,7 +549,7 @@ rm -rf unit_test_models && mkdir unit_test_models
cp -r $DATADIR/qa_model_repository/onnx_int32_int32_int32 unit_test_models/.
cp -r ${MODELDIR}/simple unit_test_models/.

SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=unit_test_models
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=unit_test_models
--trace-file=global_unittest.log --trace-level=TIMESTAMPS --trace-rate=1"
SERVER_LOG="./inference_server_cc_unit_test.log"
CLIENT_LOG="./cc_unit_test.log"
Expand Down Expand Up @@ -579,7 +579,7 @@ cp -r $DATADIR/qa_model_repository/onnx_int32_int32_int32 unit_test_models/.
rm -rf unit_test_models/onnx_int32_int32_int32/1

# Start with EXPLICIT mode and load onnx_float32_float32_float32
SERVER_ARGS="--model-repository=`pwd`/unit_test_models \
SERVER_ARGS="--allow-client-shm=true --model-repository=`pwd`/unit_test_models \
--model-control-mode=explicit \
--load-model=onnx_int32_int32_int32 \
--strict-model-config=false"
Expand Down Expand Up @@ -612,7 +612,7 @@ done
# Run python http aio unit test
PYTHON_HTTP_AIO_TEST=python_http_aio_test.py
CLIENT_LOG=`pwd`/python_http_aio_test.log
SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"
run_server
if [ "$SERVER_PID" == "0" ]; then
echo -e "\n***\n*** Failed to start $SERVER\n***"
Expand Down Expand Up @@ -660,7 +660,7 @@ cp -r ./models/simple_identity ${MODELDIR}/simple_identity_int64 && \
sed -i "s/TYPE_STRING/TYPE_INT64/" config.pbtxt && \
sed -i "s/simple_identity/simple_identity_int64/" config.pbtxt)

SERVER_ARGS="--backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"
SERVER_ARGS="--allow-client-shm=true --backend-directory=${BACKEND_DIR} --model-repository=${MODELDIR}"
SERVER_LOG="./inference_server_http_test.log"
CLIENT_LOG="./http_test.log"
run_server
Expand Down Expand Up @@ -697,7 +697,7 @@ wait $SERVER_PID
# https://github.com/mpetazzoni/sseclient
pip install sseclient-py

SERVER_ARGS="--model-repository=`pwd`/../python_models/generate_models --log-verbose=1"
SERVER_ARGS="--allow-client-shm=true --model-repository=`pwd`/../python_models/generate_models --log-verbose=1"
SERVER_LOG="./inference_server_generate_endpoint_test.log"
CLIENT_LOG="./generate_endpoint_test.log"
run_server
Expand Down Expand Up @@ -733,7 +733,7 @@ wait $SERVER_PID
### Repeated API not allowed

MODELDIR="`pwd`/models"
SERVER_ARGS="--model-repository=${MODELDIR}
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR}
--http-restricted-api=model-repository,health:k1=v1 \
--http-restricted-api=metadata,health:k2=v2"
SERVER_LOG="./http_restricted_endpoint_test.log"
Expand All @@ -755,7 +755,7 @@ fi
### Unknown API not allowed

MODELDIR="`pwd`/models"
SERVER_ARGS="--model-repository=${MODELDIR}
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR}
--http-restricted-api=model-reposit,health:k1=v1 \
--http-restricted-api=metadata,health:k2=v2"
run_server
Expand All @@ -774,7 +774,7 @@ fi
### Test Restricted APIs ###
### Restricted model-repository, metadata, and inference

SERVER_ARGS="--model-repository=${MODELDIR} \
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR} \
--http-restricted-api=model-repository:admin-key=admin-value \
--http-restricted-api=inference,metadata:infer-key=infer-value"
run_server
Expand Down Expand Up @@ -805,7 +805,7 @@ cp -r $DATADIR/qa_identity_model_repository/onnx_zero_1_float32 ${MODELDIR}/.
cp -r ./models/simple_identity ${MODELDIR}/.

# First run with default size limit - large inputs should fail
SERVER_ARGS="--model-repository=${MODELDIR}"
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR}"
SERVER_LOG="./inference_server_default_limit.log"
CLIENT_LOG="./http_input_size_limit_default.log"
run_server
Expand Down Expand Up @@ -858,7 +858,7 @@ kill $SERVER_PID
wait $SERVER_PID

# Now run with increased size limit (128MB) - large inputs should succeed
SERVER_ARGS="--model-repository=${MODELDIR} --http-max-input-size=$((2**27))"
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR} --http-max-input-size=$((2**27))"
SERVER_LOG="./inference_server_increased_limit.log"
CLIENT_LOG="./http_input_size_limit_increased.log"
run_server
Expand Down Expand Up @@ -896,7 +896,7 @@ kill $SERVER_PID
wait $SERVER_PID

# Test with zero max input size - should fail to start
SERVER_ARGS="--model-repository=${MODELDIR} --http-max-input-size=0"
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR} --http-max-input-size=0"
SERVER_LOG="./inference_server_zero_limit.log"
CLIENT_LOG="./http_input_size_limit_zero.log"
run_server
Expand All @@ -912,7 +912,7 @@ elif [ `grep -c "Error: --http-max-input-size must be greater than 0." ${SERVER_
fi

# Test with negative max input size - should fail to start
SERVER_ARGS="--model-repository=${MODELDIR} --http-max-input-size=-1024"
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR} --http-max-input-size=-1024"
SERVER_LOG="./inference_server_negative_limit.log"
CLIENT_LOG="./http_input_size_limit_negative.log"
run_server
Expand All @@ -931,7 +931,7 @@ fi
MODELDIR="`pwd`/models"
REQUEST_MANY_CHUNKS_PY="http_request_many_chunks.py"
CLIENT_LOG="./client.http_request_many_chunks.log"
SERVER_ARGS="--model-repository=${MODELDIR} --log-verbose=1 --model-control-mode=explicit --load-model=simple"
SERVER_ARGS="--allow-client-shm=true --model-repository=${MODELDIR} --log-verbose=1 --model-control-mode=explicit --load-model=simple"
SERVER_LOG="./inference_server_request_many_chunks.log"

run_server
Expand Down
Loading