sagemaker: restrict model repository paths to configured root#8630
Open
HyperPS wants to merge 2 commits intotriton-inference-server:mainfrom
Open
sagemaker: restrict model repository paths to configured root#8630HyperPS wants to merge 2 commits intotriton-inference-server:mainfrom
HyperPS wants to merge 2 commits intotriton-inference-server:mainfrom
Conversation
Signed-off-by: Sarvesh Patil <psarvesh129@gmail.com>
c2067a2 to
6165d7d
Compare
Contributor
Author
|
Hi 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security issue in the SageMaker
/modelsAPI where a user-controlledurlparameter could escape the configured model repository root.Problem
The SageMaker model load API accepted arbitrary filesystem paths without canonicalization or confinement, allowing:
/,/proc,/sys/proc/<pid>/rootFix
realpathmodel_repository_path_Security Impact
Testing
/,/proc,/sys) are rejectedEvidence
Video proof of DoS (100% CPU usage)
Related Issue
Reported via huntr LINK