build: Removed workaround to install libboost-dev. Back to apt-get install#8037
Closed
dmitry-tokarev-nv wants to merge 1 commit intomainfrom
Closed
build: Removed workaround to install libboost-dev. Back to apt-get install#8037dmitry-tokarev-nv wants to merge 1 commit intomainfrom
dmitry-tokarev-nv wants to merge 1 commit intomainfrom
Conversation
Contributor
|
I will wait on the CI to be linked. I would like to see x86, ARM, RHEL, and iGPU builds all pass with this change for approval. |
|
Thank you @mc-nv for pointing out all header files that used https://github.com/search?q=org%3Atriton-inference-server+boost%2F&type=code #include <boost/algorithm/string.hpp>
#include <boost/asio.hpp>
#include <boost/asio/post.hpp>
#include <boost/asio/thread_pool.hpp>
#include <boost/core/span.hpp>
#include <boost/functional/hash.hpp>
#include <boost/interprocess/mapped_region.hpp>
#include <boost/interprocess/shared_memory_object.hpp>
#include <boost/interprocess/managed_external_buffer.hpp>
#include <boost/interprocess/sync/interprocess_condition.hpp>
#include <boost/interprocess/sync/interprocess_mutex.hpp>
#include <boost/interprocess/sync/scoped_lock.hpp>
#include <boost/program_options.hpp>
#include <boost/thread/thread_time.hpp>
#include <boost/stacktrace.hpp>
#include <boost/interprocess/allocators/allocator.hpp>
#include <boost/interprocess/detail/atomic.hpp>
#include <boost/uuid/uuid.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>
#include <boost/interprocess/mapped_region.hpp>
#include <boost/interprocess/shared_memory_object.hpp>
#include <boost/interprocess/managed_external_buffer.hpp>
#include <boost/interprocess/sync/interprocess_condition.hpp>
int main() { return 0; }
g++ test_boost.cpp -o test_boost
echo $?
0 |
Contributor
Author
|
closed in favor of #8416 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Removed workaround to install libboost-dev.
Back to apt-get install. Since on Ubuntu 24.04 libboost-dev 1.83.0 is available to install with apt-get.
Kept the version to show that we satisfy the version requirement >= 1.78 for boost::span
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
I ran these locally
./build.py --enable-gpu --dry-run # verified Dockerfile.buildbase ./build/docker_buildTODO: run a CI pipeline
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)