feature: Enabling http-headers to support authenticated triton connections#1002
Open
satias10 wants to merge 2 commits intotriton-inference-server:mainfrom
Open
feature: Enabling http-headers to support authenticated triton connections#1002satias10 wants to merge 2 commits intotriton-inference-server:mainfrom
satias10 wants to merge 2 commits intotriton-inference-server:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new configuration option,
--triton-http-headers,which allows users to inject custom HTTP headers into Model Analyzer's internal TritonClient.Why is this needed?
Previously, users could pass headers to
perf_analyzer, but the internal Python client—responsible for loading/unloading models and checking server readiness—did not support custom headers.Key Changes:
--triton-http-headerswhich accepts a JSON string (CLI) or dictionary (YAML).TritonHTTPClientto pass these headers duringload_model,unload_model,is_server_ready, andget_model_repository_index.Verification:
[x] Unit Tests: All tests passed (
python3 -m unittest discover -s tests -t .).