fix: Respect cc_model_filenames in Python backend auto-fill#489
Open
nightflight-dk wants to merge 1 commit intotriton-inference-server:mainfrom
Open
Conversation
cfae5e6 to
5f7ac3b
Compare
Contributor
Author
|
@whoisj this helps provide cc dependent implementation part of the same repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Respect
cc_model_filenamesin Python backend auto-fillProblem
When
backendis set to"python"anddefault_model_filenameis left empty,AutoCompleteBackendFieldsunconditionally setsdefault_model_filenameto"model.py". This ignores anycc_model_filenamesmappings the user may have configured to use a custom model filename (e.g.,custom_model.pyper device).This causes the Python backend stub to always look for
model.py, even whencc_model_filenamesexplicitly maps to a different file.Fix
In
model_config_utils.cc, the auto-fill ofdefault_model_filenamenow checks thatcc_model_filenamesis also empty before defaulting to"model.py":