Merged
Conversation
pranavm-nvidia
approved these changes
Jul 10, 2025
| apt install -y --no-install-recommends clang-format-15 cmake libb64-dev rapidjson-dev libre2-dev | ||
| wget -O /tmp/boost.tar.gz https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && (cd /tmp && tar xzf boost.tar.gz) && mv /tmp/boost_1_80_0/boost /usr/include/boost && rm /tmp/boost.tar.gz | ||
| pip install build pytest | ||
| pip install build pytest pytest-asyncio |
Contributor
There was a problem hiding this comment.
I wonder how this was working before? Were the async tests added newly? In that case why didn't CI fail on the PR that introduced them?
Contributor
Author
There was a problem hiding this comment.
Explained in the description. Maybe a recent version reports async def functions are not natively supported as error which used to be just warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any new PR to core is blocked. https://github.com/triton-inference-server/core/pull/442/commits
The pipeline passed before because the following two tests were unintentionally skipped. See https://github.com/triton-inference-server/core/actions/runs/15383261092/job/43277349990.