refactor: Refactor core input size checks#382
Merged
Conversation
This was referenced Jul 23, 2024
…into yinggeh-DLIS-6657-client-input-byte-size-check
rmccorm4
reviewed
Jul 25, 2024
rmccorm4
previously approved these changes
Jul 25, 2024
Contributor
rmccorm4
left a comment
There was a problem hiding this comment.
LGTM, but left a question out of curiosity
…into yinggeh-DLIS-6657-client-input-byte-size-check
tanmayv25
reviewed
Aug 5, 2024
Contributor
tanmayv25
left a comment
There was a problem hiding this comment.
This looks more like a refactor than addition of client side byte size checks, Can you update the PR title to reflect the changes more accurately?
…into yinggeh-DLIS-6657-client-input-byte-size-check
rmccorm4
approved these changes
Aug 30, 2024
Contributor
rmccorm4
left a comment
There was a problem hiding this comment.
Thanks for adding the LLONG_MAX fix as well 🚀
…into yinggeh-DLIS-6657-client-input-byte-size-check
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/server#7592
Where should the reviewer start?
n/a
Test plan:
L0_input_validation--base
18114270
Caveats:
n/a
Background
n/a
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a