Add type hints to simple_grpc_aio_infer_client.py#878
Open
gwencasey96 wants to merge 1 commit intotriton-inference-server:mainfrom
Open
Add type hints to simple_grpc_aio_infer_client.py#878gwencasey96 wants to merge 1 commit intotriton-inference-server:mainfrom
gwencasey96 wants to merge 1 commit intotriton-inference-server:mainfrom
Conversation
This commit adds type hints to all functions in the async gRPC example: - get_triton_client: Returns InferenceServerClient - get_inputs_and_outputs: Returns tuple of inputs, outputs, and numpy arrays - get_output: Takes numpy arrays and InferResult, returns None - main: Takes argparse.Namespace, returns None Type hints improve code readability and enable static type checking with mypy. The changes follow the project's existing code style and pass all pre-commit hooks (black, isort, flake8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_grpc_aio_infer_client.pyChanges
get_triton_client: Added parameter and return type annotationsget_inputs_and_outputs: Added return type for tuple of inputs, outputs, and numpy arraysget_output: Added type hints for numpy arrays and InferResult parametermain: Added async function type hintsTest plan
🤖 Generated with Claude Code