Minor Improvements: Duplicate Cleanup, Parsing Tests, and GUI Organization#89
Minor Improvements: Duplicate Cleanup, Parsing Tests, and GUI Organization#89trembon merged 9 commits intotrembon:masterfrom
Conversation
…ase-code Fix titleId parsing regex
Enable deletion of duplicate files
…organizelibrary Fix deletion order in GUI organize
|
the code looks like it should work, but your description and name of the PR doesnt really match what the code changes are. |
Ignore .DS_Store files on macOS
|
I'm really sorry, this is my first time working on GitHub and I don't really know how these things get filled up. This commit imports the full Switch Library Manager project and applies three fixes:
Together these changes prevent resource leaks, allow callers to handle DB initialization errors, and make split file reading more reliable. Is it better structured this way? |
|
the description format wasnt the issue, the issue are that you are describing code that doesnt exist in commits in this PR. |
|
The truth is that I don't really understand many things and I do a lot of things without knowing, that is, I don't know if the process I'm doing is correct, it's the first time I've done this and I feel very lost to be honest, is there any way you can guide me on how to do it? If you're referring to these, you're correct. I don't know how to spell it or what I'm referring to. @s1rleblanc |
|
To be honest, I did help a little with the writing, because I didn't know how to fill out the changes, and all of this is new and technical for me. I hope you don't mind and can guide me with future projects. |
|
Hi @trembon , thank you again for your feedback, your patience and support Cheers! |
|
no worries, and i it looks good, will accept it :) |
This PR includes the following changes:
db0dc6d)ab44626)a740fd0).DS_Storefiles on macOS to keep the repository clean (commit:f451172)Several previously merged internal PRs are also included and consolidated in this branch.
No changes were made to files such as
settings.go,persistentDB.go, orsplitFileReader.goin this PR.