Skip to content

Minor Improvements: Duplicate Cleanup, Parsing Tests, and GUI Organization#89

Merged
trembon merged 9 commits intotrembon:masterfrom
s1rleblanc:master
Jun 22, 2025
Merged

Minor Improvements: Duplicate Cleanup, Parsing Tests, and GUI Organization#89
trembon merged 9 commits intotrembon:masterfrom
s1rleblanc:master

Conversation

@s1rleblanc
Copy link
Copy Markdown

@s1rleblanc s1rleblanc commented Jun 9, 2025

This PR includes the following changes:

  • Fixed regex for title ID parsing and added tests (commit: db0dc6d)
  • Removed duplicate files when cleaning up old updates (commit: ab44626)
  • Reordered the deletion step in the GUI organizer (commit: a740fd0)
  • Ignored .DS_Store files on macOS to keep the repository clean (commit: f451172)

Several previously merged internal PRs are also included and consolidated in this branch.
No changes were made to files such as settings.go, persistentDB.go, or splitFileReader.go in this PR.

@trembon
Copy link
Copy Markdown
Owner

trembon commented Jun 10, 2025

the code looks like it should work, but your description and name of the PR doesnt really match what the code changes are.
can you look it over so they match the code changes and we can understand the changes more?

@s1rleblanc
Copy link
Copy Markdown
Author

I'm really sorry, this is my first time working on GitHub and I don't really know how these things get filled up.

This commit imports the full Switch Library Manager project and applies three fixes:

  1. Close opened settings files

    • Added defer file.Close() in ReadSettingsAsJSON and ReadSettings (src/settings/settings.go) so file handles are always released.
  2. Fix Bolt DB initialization

    • NewPersistentDB (src/db/persistentDB.go) now sets a 60‑second timeout (Timeout: 60 * time.Second) and returns initialization errors instead of calling log.Fatal.
  3. Enable retries when reading split files

    • _openFile (src/switchfs/splitFileReader.go) passes retry.Attempts(5) to retry.Do, ensuring file opens are retried up to five times.

Together these changes prevent resource leaks, allow callers to handle DB initialization errors, and make split file reading more reliable.

Is it better structured this way?

@trembon
Copy link
Copy Markdown
Owner

trembon commented Jun 12, 2025

the description format wasnt the issue, the issue are that you are describing code that doesnt exist in commits in this PR.
the current description feels AI generated from something else, maybe suggestions AI have for this repo?

@s1rleblanc
Copy link
Copy Markdown
Author

The truth is that I don't really understand many things and I do a lot of things without knowing, that is, I don't know if the process I'm doing is correct, it's the first time I've done this and I feel very lost to be honest, is there any way you can guide me on how to do it?

If you're referring to these, you're correct. I don't know how to spell it or what I'm referring to.

@s1rleblanc
Fix title ID parsing regex and add tests
db0dc6d
@s1rleblanc
Merge pull request s1rleblanc#1 from s1rleblanc/codex/detect-and-fix-error-on-b…
a7960ee
@s1rleblanc
Delete duplicates when cleaning old updates
ab44626
@s1rleblanc
Merge pull request s1rleblanc#2 from s1rleblanc/review-duplicate-file-removal
3a259ab
@s1rleblanc
Reorder deletion step in GUI organize
a740fd0
@s1rleblanc
Merge pull request s1rleblanc#3 from s1rleblanc/codex/reorder-process-calls-in-…
3dac050
@s1rleblanc
Merge branch 'trembon:master' into master

@s1rleblanc
Copy link
Copy Markdown
Author

To be honest, I did help a little with the writing, because I didn't know how to fill out the changes, and all of this is new and technical for me. I hope you don't mind and can guide me with future projects.

@s1rleblanc s1rleblanc changed the title Add Switch Library Manager project Minor Improvements: Duplicate Cleanup, Parsing Tests, and GUI Organization Jun 16, 2025
@s1rleblanc
Copy link
Copy Markdown
Author

Hi @trembon , thank you again for your feedback, your patience and support
I have investigated a little more and I have tried to document myself a little more, I have edited my first comment with what I think are the adjustments you commented from the beginning giving him another format and trying to be clearer with the changes I propose, I hope you accept them to be able to see part of my work published next to yours.

Cheers!

@trembon
Copy link
Copy Markdown
Owner

trembon commented Jun 22, 2025

no worries, and i it looks good, will accept it :)

@trembon trembon merged commit 701ae2c into trembon:master Jun 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants