Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
heyllog
changed the base branch from
feat/TON-376-swap-design
to
feat/TON-729-staking-ui
| /** | ||
| * Maximum fiat amount allowed | ||
| */ | ||
| maxBaseAmount: number; |
Contributor
There was a problem hiding this comment.
@heyllog For example, if it's 1.3 USD, this field will contain 130 (cents) or 1.3? If 1.3 then shouldn't we have some raw values in cents? This related to all fields - both crypto and fiat.
| /** | ||
| * Provider-specific metadata for the quote | ||
| */ | ||
| metadata?: unknown; |
| /** | ||
| * Amount to onramp (either fiat or crypto, depending on isFiatAmount) | ||
| */ | ||
| amount: string; |
| * E.g. credit_card, bank_transfer. Limits the payment methods available. | ||
| * Often not strictly required by convert endpoint but can be passed. | ||
| */ | ||
| paymentMethod?: string; |
Contributor
There was a problem hiding this comment.
@heyllog Can we make more specific values here if we know them?
| /** | ||
| * Custom options for Mercuryo requests | ||
| */ | ||
| export interface MercuryoQuoteOptions { |
Contributor
There was a problem hiding this comment.
@heyllog Shouldn't we have MercuryoQuoteOptions and MercuryoOnrampOptions in models? We need them on mobile platforms also
| /** | ||
| * E.g. credit_card, google_pay, apple_pay. Limits the payment methods available. | ||
| */ | ||
| paymentMethod?: string; |
Contributor
There was a problem hiding this comment.
@heyllog Same question here - more specific values instead of string if mossible
| /** | ||
| * Custom options for Moonpay requests | ||
| */ | ||
| export interface MoonpayQuoteOptions { |
| /** | ||
| * Custom options for TonPay requests | ||
| */ | ||
| export interface TonPayQuoteOptions { |
|
|
||
| export class OnrampError extends DefiManagerError { | ||
| static readonly PROVIDER_ERROR = 'PROVIDER_ERROR'; | ||
| static readonly InvalidParams = 'INVALID_ONRAMP_PARAMS'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.