Skip to content

Fix tests for setuptools >= 70 which removed tests_require #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toabctl merged 2 commits into from
Mar 10, 2026
Merged

Fix tests for setuptools >= 70 which removed tests_require #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b34d241
Fix tests for setuptools >= 70 which removed tests_require
toabctl Mar 10, 2026
ac2048d
Fix flake8 lint: use parametrize for tests_require instead of list co…
toabctl Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 130 additions & 90 deletions metaextract/tests/test_metaextract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,19 @@
import sys
import tarfile

import setuptools

from metaextract import utils as meta_utils


base_dir = os.path.dirname(__file__)
fixtures_base_dir = os.path.join(base_dir, "fixtures")

# setuptools >= 70 removed the tests_require attribute from Distribution
_HAS_TESTS_REQUIRE = hasattr(
setuptools.Distribution({}), 'tests_require'
)


@pytest.fixture()
def tararchive(tmpdir):
Expand Down Expand Up @@ -141,100 +148,129 @@ def test_no_setup_py(self, tmpdir):
meta_utils._setup_py_run_from_dir(tmpdir.strpath, sys.executable)
assert tmpdir.strpath in str(e_info.value)

@pytest.mark.parametrize("fixture_name,expected_data", [
(
"setuptools_simple", {
'entry_points': None, 'extras_require': {'extra1': ['pkg1']},
'install_requires': ['bar', 'foo'], 'python_requires': None,
'setup_requires': [], 'has_ext_modules': None,
'scripts': None, 'data_files': None, 'tests_require': None}
),
(
"setuptools_simple_unicode", {
'entry_points': None, 'extras_require': {
'extra1': ['pkg1'], 'extra2': ['pkg2', 'pkg3']},
'install_requires': ['bar', 'foo'], 'python_requires': None,
'setup_requires': [], 'has_ext_modules': None,
'scripts': None, 'data_files': None, 'tests_require': None}
),
(
"setuptools_simple_unicode_and_header", {
'entry_points': None, 'extras_require': {},
'install_requires': ['bar', 'foo'], 'python_requires': None,
'setup_requires': [], 'has_ext_modules': None,
'scripts': None, 'data_files': None, 'tests_require': None}
),
(
"setuptools_full", {
'install_requires': ['bar', 'foo'], 'setup_requires': [],
'python_requires': '>=2.6,!=3.0.*,!=3.1.*,!=3.2.*',
'has_ext_modules': None, 'scripts': ['scripts/testpkg'],
'data_files': [
['man/man1', ['doc/testpkg.1']],
['share/doc/testpgk',
['AUTHORS', 'LICENSE', 'README.rst']],
['share/doc/testpkg/html', ['doc/testpkg.html']],
], 'tests_require': ['testpkg1'], 'entry_points':
{
'console_scripts': ['testpkgp1=testpkg:main']
},
'extras_require': {
'extra1': ['ex11', 'ex12'],
'extra2': ['ex21>=3.4', 'ex22!=0.15.0,>=0.11.0']
@pytest.mark.parametrize(
"fixture_name,expected_data,expected_tests_require", [
(
"setuptools_simple", {
'entry_points': None,
'extras_require': {'extra1': ['pkg1']},
'install_requires': ['bar', 'foo'],
'python_requires': None,
'setup_requires': [],
'has_ext_modules': None,
'scripts': None, 'data_files': None},
None
),
(
"setuptools_simple_unicode", {
'entry_points': None, 'extras_require': {
'extra1': ['pkg1'], 'extra2': ['pkg2', 'pkg3']},
'install_requires': ['bar', 'foo'],
'python_requires': None,
'setup_requires': [],
'has_ext_modules': None,
'scripts': None, 'data_files': None},
None
),
(
"setuptools_simple_unicode_and_header", {
'entry_points': None, 'extras_require': {},
'install_requires': ['bar', 'foo'],
'python_requires': None,
'setup_requires': [],
'has_ext_modules': None,
'scripts': None, 'data_files': None},
None
),
(
"setuptools_full", {
'install_requires': ['bar', 'foo'],
'setup_requires': [],
'python_requires':
'>=2.6,!=3.0.*,!=3.1.*,!=3.2.*',
'has_ext_modules': None,
'scripts': ['scripts/testpkg'],
'data_files': [
['man/man1', ['doc/testpkg.1']],
['share/doc/testpgk',
['AUTHORS', 'LICENSE', 'README.rst']],
['share/doc/testpkg/html',
['doc/testpkg.html']],
], 'entry_points': {
'console_scripts': [
'testpkgp1=testpkg:main']
},
'extras_require': {
'extra1': ['ex11', 'ex12'],
'extra2': ['ex21>=3.4',
'ex22!=0.15.0,>=0.11.0']
},
'version': '1.2.3',
'name': 'testpkg',
'fullname': 'testpkg-1.2.3',
'description': 'desc',
'long_description': 'long desc',
'classifiers': [
'Intended Audience :: Developers'],
'license': 'Apache-2.0',
},
'version': '1.2.3',
'name': 'testpkg',
'fullname': 'testpkg-1.2.3',
'description': 'desc',
'long_description': 'long desc',
'classifiers': ['Intended Audience :: Developers'],
'license': 'Apache-2.0',

}
),
(
"distutils_simple",
{'data_files': None, 'has_ext_modules': None, 'scripts': None,
'version': '1.0'}
),
(
"distutils_with_extension",
{'data_files': None, 'has_ext_modules': True, 'scripts': None}
),
(
"pbr_simple",
{'entry_points': {'console_scripts': ['entry2 = pkg1:main']},
'extras_require': {}, 'install_requires': [],
'python_requires': None, 'setup_requires': ['pbr>=1.0'],
'has_ext_modules': None, 'scripts': None, 'data_files': None,
'tests_require': None,
'version': '1'}
),
(
"pyproject",
{
'install_requires': ['bar', 'foo'], 'setup_requires': [],
'python_requires': '!=3.0.*,!=3.1.*,!=3.2.*,>=2.6',
'entry_points':
['testpkg1']
),
(
"distutils_simple",
{'data_files': None, 'has_ext_modules': None,
'scripts': None, 'version': '1.0'},
None
),
(
"distutils_with_extension",
{'data_files': None, 'has_ext_modules': True,
'scripts': None},
None
),
(
"pbr_simple",
{'entry_points': {
'console_scripts': ['entry2 = pkg1:main']},
'extras_require': {}, 'install_requires': [],
'python_requires': None,
'setup_requires': ['pbr>=1.0'],
'has_ext_modules': None,
'scripts': None, 'data_files': None,
'version': '1'},
None
),
(
"pyproject",
{
'console_scripts': ['testpkgp1 = testpkg:main']
},
'extras_require': {
'extra1': ['ex11', 'ex12'],
'extra2': ['ex21>=3.4', 'ex22!=0.15.0,>=0.11.0']
'install_requires': ['bar', 'foo'],
'setup_requires': [],
'python_requires':
'!=3.0.*,!=3.1.*,!=3.2.*,>=2.6',
'entry_points': {
'console_scripts': [
'testpkgp1 = testpkg:main']
},
'extras_require': {
'extra1': ['ex11', 'ex12'],
'extra2': ['ex21>=3.4',
'ex22!=0.15.0,>=0.11.0']
},
'version': '1.2.3',
'name': 'testpkg',
'fullname': 'testpkg-1.2.3',
'description': 'desc',
'long_description': 'long desc\n',
'classifiers': [
'Intended Audience :: Developers'],
'license': 'Apache-2.0',
},
'version': '1.2.3',
'name': 'testpkg',
'fullname': 'testpkg-1.2.3',
'description': 'desc',
'long_description': 'long desc\n',
'classifiers': ['Intended Audience :: Developers'],
'license': 'Apache-2.0',
}
),
])
None
),
])
def test_run_setup_py_from_dir(self, tmpdir, monkeypatch,
fixture_name, expected_data):
fixture_name, expected_data,
expected_tests_require):
if fixture_name == "pyproject" and sys.version_info < (3, 0):
pytest.skip("pyproject.toml is not supported for python2")

Expand All @@ -250,3 +286,7 @@ def test_run_setup_py_from_dir(self, tmpdir, monkeypatch,
for expected_key, expected_val in expected_data.items():
assert expected_key in data['data']
assert data['data'][expected_key] == expected_val
# setuptools >= 70 removed tests_require from Distribution
if _HAS_TESTS_REQUIRE:
assert data['data'].get('tests_require') == \
expected_tests_require