Added community modules as a git submodule#256
Conversation
There was a problem hiding this comment.
I recommend following the main branch instead of pinning it to a specific commit.
There was a problem hiding this comment.
I am not entirely sure that is possible, but I tried nonetheless (see .gitmodules file)
There was a problem hiding this comment.
If Git itself doesn’t support this, one option would be to have tlapm’s GitHub automation download and extract CommunityModules.zip as part of the build process.
This wouldn’t solve the local development setup, but in practice that already requires fetching dependencies (e.g., via opam), so this wouldn’t be introducing a fundamentally new requirement.
More importantly, it would align tlapm with how other projects (tlaplus/tlapus and tlaplus/vscode-tlaplus) consume tlaplus/CommunityModules.
Should fix CI and unit test failures Signed-off-by: Andrew Helwer <ahelwer@pm.me>
|
Closing in favor of an approach where the build system runs a wget on the latest CommunityModules release |
2 participants
Should fix CI and unit test failures
Ref #252