Simplify TurnkeySigner: collapse signing methods, move activity logic to CLI#20
Open
natefikru wants to merge 2 commits intonatefikru/eng-3860-tk-cli-commandsfrom
Open
Conversation
… to CLI Collapse sign_ed25519 and sign_ssh_auth_payload into a single sign_raw_payload method since they were identical. Remove approve_activity and reject_activity from TurnkeySigner, moving the API calls to the CLI activity command using client() directly. This removes the silent swallow of already-rejected status from reject, letting the CLI decide how to handle errors.
Treat UnexpectedActivityStatus(REJECTED) as success in tk activity reject so retries and races do not fail with a hard error when the activity was already rejected by another actor.
Contributor
Author
|
@emostov does |
Collaborator
Yes - it doesn't go through the parser at all so you can only write consensus policies against it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sign_ed25519andsign_ssh_auth_payloadinto a singlesign_raw_payloadmethod (they were identical wrappers)approve_activityandreject_activityfromTurnkeySigner, move API calls to the CLI activity command usingclient()directlyTest plan