Add regression tests for VM native module filename fallbacks#35
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
Add regression tests for VM native module filename fallbacks#35cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor[bot] wants to merge 1 commit intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/qcommon/vm_native_module_names.c/.h) without changing loader behaviorunit_vm_native_module_names)Risky behavior now covered
module.somodule.arch.somodulearch.soTest files added/updated
tests/unit/test_vm_native_module_names.csrc/qcommon/vm_native_module_names.csrc/qcommon/vm_native_module_names.hsrc/qcommon/vm.c(uses helper, behavior-preserving refactor)CMakeLists.txt(register new unit target/test)Validation run
cmake -S /workspace -B /workspace/build-vk-Releasecmake --build /workspace/build-vk-Release --target unit_vm_native_module_names unit_macros -j4ctest -R "unit_(macros|vm_native_module_names)" --output-on-failure -V(passed)Why this materially reduces regression risk
Native VM loading is a core startup path with high blast radius: if fallback filename formatting/order regresses, game/client/ui modules can fail to load at runtime. These tests lock the exact candidate contract and edge-condition behavior, catching subtle naming/fallback regressions early without requiring platform-specific runtime setups.