Add VM native module loader regression coverage#34
Draft
cursor[bot] wants to merge 2 commits intonext-gen-5from
Draft
Add VM native module loader regression coverage#34cursor[bot] wants to merge 2 commits intonext-gen-5from
cursor[bot] wants to merge 2 commits intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused unit-test coverage for native VM module fallback name resolution introduced in recent VM loader changes, with a minimal testability refactor that preserves runtime behavior.
Risky behavior now covered
VM_TryLoadNativeModule:module.somodule.<arch>.somodule<arch>.soThese paths are high blast-radius because they affect dynamic loading for core modules (
game/cgame/uialiases) and fallback behavior across architectures.Test files added/updated
tests/unit/test_vm_native_loader.csrc/qcommon/vm_native_loader.csrc/qcommon/vm_native_loader.hsrc/qcommon/vm.c(uses extracted helper in existing load flow)CMakeLists.txt(registersunit_vm_native_loadertarget/test)Why this materially reduces regression risk
module.<arch>.sosupport) from shipping unnoticed.Validation
cmake -S /workspace -B /workspace/build-vk-Releasecmake --build /workspace/build-vk-Release --target unit_vm_native_loaderctest -R unit_vm_native_loader --output-on-failure