Audio: add CTC to PTL rt5682 path.#10696
Conversation
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks good, just the opens already mentioned.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
1d53704 to
63efc72
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
There a lot of change here including in common files, can you add more context in the commit message especially around the changes in any common files.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
63efc72 to
c74ac5a
Compare
|
Added more details in the commit message now. Thanks! |
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
c74ac5a to
12be0cd
Compare
| { | ||
| source "host-copier.$HEADSET_PCM_ID.playback" | ||
| sink "gain.1.1" | ||
| } | ||
| { | ||
| source "host-copier.$SPEAKER_PCM_ID.playback" | ||
| sink "gain.3.1" | ||
| } |
There was a problem hiding this comment.
...delete this here, wont this impact users who are not using CTC/DAX with this codec ?
There was a problem hiding this comment.
Thanks! This change is not really neccesary.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
12be0cd to
20d34d4
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Almost ready, just one question.
| { | ||
| source "dai-copier.SSP.$HEADSET_CODEC_NAME.capture" | ||
| sink "host-copier.$HEADSET_PCM_ID.capture" | ||
| } |
There was a problem hiding this comment.
If this is needed for CTC/DAX only then it should depend on USE_CTC_SPK or similar or it may break other users who dont have CTC/DAX.
There was a problem hiding this comment.
Excuse me, this change is also not required.
Thanks for catching it
Include CTC component in PTL with rt5682. Introduce `USE_CTC_SPK` in `cavs-mixin-mixout-dax-ssp.conf` to conditionally include CTC component in the pipeline. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
20d34d4 to
19be29b
Compare
3 participants
Include CTC component in PTL with rt5682.