ASoC: SOF: Intel: add an empty adr_link#5746
Open
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: Intel: add an empty adr_link#5746bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
An empty adr_link is expected to terminate the for (adr_link = mach_params->links; adr_link->num_adr; adr_link++) loop. Allocate link_num + 1 links to add an empty adr_link. Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an out-of-bounds/unterminated iteration risk when generating the default SoundWire (sof_sdw) machine by ensuring the dynamically-allocated snd_soc_acpi_link_adr array has a zeroed terminator entry (num_adr == 0), matching how asoc_sdw_utils iterates mach_params->links.
Changes:
- Allocate
link_num + 1snd_soc_acpi_link_adrentries so the final entry is an empty terminator forfor (adr_link = mach_params->links; adr_link->num_adr; adr_link++). - Add an explanatory comment near the allocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| link_num = hweight32(link_mask); | ||
| links = devm_kcalloc(sdev->dev, link_num, sizeof(*links), GFP_KERNEL); | ||
| /* An empty adr_link is need to terminate the adr_link loop */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty adr_link is expected to terminate the
for (adr_link = mach_params->links; adr_link->num_adr; adr_link++) loop. Allocate link_num + 1 links to add an empty adr_link.
Fixes: 5226d19 ("ASoC: SOF: Intel: use sof_sdw as default SDW machine driver")