Merged
Conversation
This ensures the thing we pass actually has a length. Signed-off-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Stephen Finucane <stephen@that.guru>
This will always raise an exception. Signed-off-by: Stephen Finucane <stephen@that.guru>
This ensures that we don't lose type information for the return value. Signed-off-by: Stephen Finucane <stephen@that.guru>
This ensures we don't lose type information on the `exception` attribute
of the context manager:
with self.assertRaises(ValueError) as ctx:
int("foo")
reveal_type(ctx.exception) # now reveals ValueError
We also narrow the tuple type, but varadic expansion is not a thing yet,
so we need explicitly type for different lengths of tuple. We decide
that at most 3 exceptions can be passed: any more and you'll lose this
information, which seems fair.
Signed-off-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A grab bag of small tweaks.