Open
Conversation
|
|
Contributor
|
@chndler This PR adds third party protos, but doesn't modify the cloud protos at all. Is that really what you meant to do? If so, how are those extra protos useful to us? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested:
Note
Low Risk
Low risk: changes are limited to build configuration and added
.protodescriptor/option definitions; primary risk is build/proto-generation breakage due to new third-party protos or source-set ordering/exclusions.Overview
Updates
temporal-serviceclientproto generation to include a newsrc/main/proto-thirdpartysource directory.Vendors gRPC-Gateway
protoc-gen-openapiv2option protos (annotations.proto,openapiv2.proto) so the project can compile against newer Temporal Cloud API protos that reference these OpenAPI annotations.Written by Cursor Bugbot for commit 5791937. This will update automatically on new commits. Configure here.