feat: Add LOCK_TIMEOUT connection setting#1694
Open
etinquis wants to merge 2 commits intotediousjs:masterfrom
Open
feat: Add LOCK_TIMEOUT connection setting#1694etinquis wants to merge 2 commits intotediousjs:masterfrom
etinquis wants to merge 2 commits intotediousjs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
- Coverage 78.84% 78.82% -0.02%
==========================================
Files 90 90
Lines 4887 4893 +6
Branches 920 923 +3
==========================================
+ Hits 3853 3857 +4
- Misses 736 737 +1
- Partials 298 299 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new lockTimeout connection setting, which sets LOCK_TIMEOUT (https://learn.microsoft.com/en-us/sql/t-sql/statements/set-lock-timeout-transact-sql) along with the existing connection preamble statements.
Before submitting a PR :
masterbranch of the repository.npm installin the root folder.npm run-script test-all). During development, to run individual test usenode_modules/nodeunit test/<test_file.js> -t <test_name>.npm run build).npm run lint).node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.Thank you for Contributing!