Use TIM2 Output Compare to autotrigger GPIO pin#17
Draft
jfedor2 wants to merge 1 commit intoteamfinalmouse:mainfrom
Draft
Use TIM2 Output Compare to autotrigger GPIO pin#17jfedor2 wants to merge 1 commit intoteamfinalmouse:mainfrom
jfedor2 wants to merge 1 commit intoteamfinalmouse:mainfrom
Conversation
Makes it so that triggering the GPIO pin is uniformly spread over a span of 1ms by using the timer output compare function. Because the pin toggling is done in hardware, the timing is not affected by interrupt handlers and higher prority threads. Changes the GPIO pin used from PB15 (Arduino D11) to PA15 (Arduino D9). Doesn't take the "Auto-trigger Level" setting into consideration.
Contributor
Author
|
This is a proof-of-concept proposed solution for #16. |
jfedor2
commented
Oct 8, 2024
| HAL_GPIO_WritePin(ARDUINO_D11_GPIO_Port, ARDUINO_D11_Pin, auto_trigger_level_high ? GPIO_PIN_SET : GPIO_PIN_RESET); | ||
| uint32_t delay = rand() % 1000 + 100; | ||
| last_btn_gpio_timestamp = xlat_counter_1mhz_get() + delay; | ||
| htim2.Instance->CCR1 = last_btn_gpio_timestamp; |
Contributor
Author
There was a problem hiding this comment.
I think there's a potential issue if we get interrupted for longer than the chosen delay time before this line as the output compare function checks for exact match, so we might miss it. Could possibly solve it with PWM mode or just making the delay long enough.
| void xlat_auto_trigger_turn_off_action(void) | ||
| { | ||
| HAL_GPIO_WritePin(ARDUINO_D11_GPIO_Port, ARDUINO_D11_Pin, auto_trigger_level_high ? GPIO_PIN_RESET : GPIO_PIN_SET); | ||
| htim2.Instance->CCR1 = xlat_counter_1mhz_get() + 100; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so that triggering the GPIO pin is uniformly spread over a span of 1ms by using the timer output compare function.
Because the pin toggling is done in hardware, the timing is not affected by interrupt handlers and higher prority threads.
Changes the GPIO pin used from PB15 (Arduino D11) to PA15 (Arduino D9).
Doesn't take the "Auto-trigger Level" setting into consideration.