Generalize LF normalization for test input fixtures#10
Open
Meredith2328 wants to merge 1 commit intotea-compiler:mainfrom
Open
Generalize LF normalization for test input fixtures#10Meredith2328 wants to merge 1 commit intotea-compiler:mainfrom
Meredith2328 wants to merge 1 commit intotea-compiler:mainfrom
Conversation
The original fix pinned LF handling to expr_eval.in only. Expanding the rule to all test input fixtures keeps line-ending behavior consistent across Windows checkouts without requiring file-by-file follow-up patches. Constraint: Test input files under tests/ may be checked out with CRLF on Windows Rejected: Keep a single-file rule for expr_eval.in | leaves the same risk for other input fixtures Confidence: high Scope-risk: narrow Reversibility: clean Directive: If a future fixture truly needs platform-native endings, carve it out explicitly instead of narrowing the wildcard Tested: git check-attr on multiple tests/*.in files Tested: cargo test expr_eval -- --nocapture (blocked at gcc lookup, not line-ending parsing) Not-tested: Full cargo test in an environment with gcc available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the same as #4 (which was closed by mistake) and generalizes LF fix to
*.in.When
core.autocrlfis configured in Git or when running on Windows,the
expr_evaltest readstests/expr_eval/expr_eval.inand failsif the file uses CRLF line endings (due to cloning or auto-conversion).
Pic1:
expr_eval.inusing CRLF, and the test failedPic2:
expr_eval.inusing LF, and the test passedThis pull request updates the
.gitattributesfile to enforce properline ending handling for test input files:
text=auto eol=lffortests/expr_eval/expr_eval.in