Skip to content

Fixes upstream bug #3604 in NetQueryDispatcher#3605

Open
TKIPisalegacycipher wants to merge 1 commit intotdlib:masterfrom
TKIPisalegacycipher:fix/netquery-dispatcher-custom-photos-fix
Open

Fixes upstream bug #3604 in NetQueryDispatcher#3605
TKIPisalegacycipher wants to merge 1 commit intotdlib:masterfrom
TKIPisalegacycipher:fix/netquery-dispatcher-custom-photos-fix

Conversation

@TKIPisalegacycipher
Copy link

Fixes #3604 and thus for downstream clients should fix custom contact photos. Fix applied at NetQueryDispatcher.cpp:392-401. Now, when a FILE_MIGRATE_N error (code 303) arrives:

  1. try_fix_migrate() now matches the FILE_MIGRATE_ prefix
  2. Extracts the target DC ID, validates it
  3. Resends the query to that DC — without changing the main DC (unlike PHONE/NETWORK/USER_MIGRATE_)
  4. The query re-enters dispatch() in Query state and gets routed to the correct DC

Thanks for your time considering this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FILE_MIGRATE_ errors not handled for file downloads (or: why custom contact photos don't work)

1 participant