[build] Fix editable build dependency compatibility#8789
Open
yunusberndt wants to merge 1 commit intotaichi-dev:masterfrom
Open
[build] Fix editable build dependency compatibility#8789yunusberndt wants to merge 1 commit intotaichi-dev:masterfrom
yunusberndt wants to merge 1 commit intotaichi-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Brief Summary
Walkthrough
setup.pybuild/dependency handling for current toolchain behavior.requirements_dev.txtto consistent compatible versions.Note
Low Risk
Low risk build-tooling change that only affects development dependencies and
setup.py cleanbehavior; main risk is cleanup not running correctly under unusual setuptools/distutils versions.Overview
Improves editable/develop build compatibility by pinning
setuptools<82inrequirements_dev.txt.Updates
setup.py’sCleancommand to remove build artifacts via a new_remove_tree_compat()helper that adapts toremove_tree()signature differences across setuptools/distutils versions (respectingdry_runwhen supported).Written by Cursor Bugbot for commit fa2a716. This will update automatically on new commits. Configure here.