Open
Conversation
- I wouldn't say I like docker, but I didn't want to install npm on my
own computer to build this, so created a quick Dockerfile. It seems
to work for me, so I may as well make it useful to others.
- This is capable of running as-is, but I also used it to extract the
built files out and host them elsewhere.
- I now realize there was a simpler way to do this (get built files
from the gh-pages branch), so I probably won't use this anymore.
Still, maybe useful to someone? I have no problems if this is
rejected as extra complexity.
- Review
- I wouldn't call myself a docker expert, so a review of that aspect
would be welcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
own computer to build this, so created a quick Dockerfile. It seems
to work for me, so I may as well make it useful to others.
built files out and host them elsewhere.
from the gh-pages branch), so I probably won't use this anymore.
Still, maybe useful to someone? I have no problems if this is
rejected as extra complexity.
would be welcome.