Skip to content

7683 Contract Updates#197

Merged
evchip merged 8 commits intocanaryfrom
bugfix/audit/c1-4
Sep 30, 2025
Merged

7683 Contract Updates#197
evchip merged 8 commits intocanaryfrom
bugfix/audit/c1-4

Conversation

@rymcol
Copy link
Copy Markdown
Contributor

@rymcol rymcol commented Sep 25, 2025

Description

Fixes:

  • orderId calculation due to divergent orderData fields
  • verify counterpart in ReadRequest

Motivation and Context

This prevents edge cases in bridge transactions

How Has This Been Tested?

manually

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

@rymcol rymcol self-assigned this Sep 25, 2025
@rymcol rymcol changed the title 7683 Contract Updates Draft: 7683 Contract Updates Sep 25, 2025
@rymcol rymcol changed the title Draft: 7683 Contract Updates 7683 Contract Updates Sep 30, 2025
@rymcol rymcol requested a review from evchip September 30, 2025 16:14
Copy link
Copy Markdown
Contributor

@evchip evchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ty

@evchip evchip merged commit b3c2e13 into canary Sep 30, 2025
4 checks passed
@evchip evchip deleted the bugfix/audit/c1-4 branch September 30, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants