Open
Conversation
de7f517 to
714d493
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
jvsena42
reviewed
Mar 11, 2026
jvsena42
previously requested changes
Mar 11, 2026
Member
jvsena42
left a comment
There was a problem hiding this comment.
Found this bug when double tapping the NumberPad
Screen_recording_20260311_143238.webm
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Fixed the NumberPad double-tap issue in 32711b8 — added a Previewfix.mp4 |
32711b8 to
72ce56a
Compare
Collaborator
Author
|
Addressed both review comments in fb7168a:
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fb7168a to
6fe4f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #831
This PR:
Description
Rapid taps on clickable elements (buttons, navigation icons, tabbar buttons, drawer items, overlays, etc) could trigger duplicate actions (double navigations, duplicate payments, etc.). A
ClickDebouncerutility with a 500ms window is added and exposed asrememberDebouncedClick. All interactive surfaces now route through debounced click handlers.The scan deduplication consolidates four separate
handleScan()call sites into a singlelaunchScan()method that tracks the active scan job and input, cancelling prior scans when a new one arrives and skipping exact duplicates.Preview
before.mp4
multiClicks.mp4
multiPaste.mp4
QA Notes
1. Button debouncing
2. Navigation debouncing
3. Tabbar buttons and drawer items
4. Scan deduplication - bug: #831
5. Overlay and sheet dismissal