[Sema] Skip redundant MainActor suggestion on conformance#88602
Open
qflen wants to merge 1 commit intoswiftlang:mainfrom
Open
[Sema] Skip redundant MainActor suggestion on conformance#88602qflen wants to merge 1 commit intoswiftlang:mainfrom
qflen wants to merge 1 commit intoswiftlang:mainfrom
Conversation
qflen
changed the title
Fixes swiftlang#87776. When the conforming nominal already carries the suggested global actor, skip the note that advises isolating the conformance to that actor: writing the attribute on the conformance would be redundant with the nominal's isolation. The suggestion still fires for nominals with a different or no global actor, and for conformances explicitly marked 'nonisolated' (a deliberate user choice that may warrant reconsideration). Also fixes a latent assertion failure in isolationsMatch when an isolation is neither a global actor nor an actor instance.
qflen
force-pushed
the
fix-redundant-isolate-conformance-note
branch
from
3ca6867 to
e394bdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@MainActor" fired even when the conforming nominal already carried@MainActor, producing a redundant fix-it.diagnoseConformanceIsolationErrors, skip the suggestion whengetActorIsolation(nominal)matches the accumulatedpotentialIsolation, unless the conformance is explicitlynonisolated(in which case the note still fires as a prompt to reconsider).isolationsMatchthat fired when either isolation was neither a global actor nor an actor instance.Test plan
test/Concurrency/isolated_conformance.swift(incl. newIssue87776regression): 1/1 passed.test/Concurrencysuite: 451/451 supported passed, 14 unsupported, 0 failures.